linux-kernel - Re: [RFC][PATCH] tracing: Show available event triggers when no trigger is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140109170645.17c819ae@gandalf.local.home>
Date:	Thu, 9 Jan 2014 17:06:45 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [RFC][PATCH] tracing: Show available event triggers when no
 trigger is set

On Wed, 08 Jan 2014 16:50:47 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> [SNIP]
> > +	if (v == SHOW_AVAILABLE_TRIGGERS) {
> > +		seq_puts(m, "# Available triggers:\n");
> > +		seq_putc(m, '#');
> > +		mutex_lock(&trigger_cmd_mutex);
> > +		list_for_each_entry(p, &trigger_commands, list)
> 
> I guess the list_for_each_entry_reverse() will give a more intuitive
> result here:
> 
>   [root /sys/kernel/debug/tracing]# cat events/sched/sched_switch/trigger
>   # Available triggers:
>   # traceon traceoff snapshot stacktrace enable_event disable_event
> 

Updated. Thanks for the review.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/