linux-kernel - Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140109184554.54524159@gandalf.local.home>
Date:	Thu, 9 Jan 2014 18:45:54 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Eric Paris <eparis@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Dave Chinner <david@...morbit.com>,
	linux-fsdevel@...r.kernel.org,
	James Morris <james.l.morris@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	"Theodore Ts'o" <tytso@....edu>, stable <stable@...r.kernel.org>,
	Paul Moore <paul@...l-moore.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Matthew Wilcox <matthew@....cx>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] vfs: Fix possible NULL pointer dereference in
 inode_permission()

On Thu, 09 Jan 2014 18:37:06 -0500
Eric Paris <eparis@...hat.com> wrote:


> > Oh wait, you said not to clear the member. Thus, the patch would look
> > like this:
> > 
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> SMACK also needs this change somehow in smack_inode_free_security()
> 
> but at least from an SELinux PoV, I think it's quick and easy, but wrong
> for maintainability...

I agree, but for this late in the -rc window, this may be the best
thing for now. We can think of a better solution for the future.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/