linux-kernel - Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52CE4496.5030401@synopsys.com>
Date:	Thu, 9 Jan 2014 12:11:26 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Chen Gang <gang.chen.5i5j@...il.com>
CC:	Michal Marek <mmarek@...e.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new
 line character in the macro

Forwarding to Chen's email address:

On Monday 06 January 2014 02:56 PM, Michal Marek wrote:
> On 2014-01-06 06:36, Vineet Gupta wrote:
>> Hi Michal,
>>
>> On Friday 03 January 2014 06:08 PM, Michal Marek wrote:
>>> On 2013-11-21 10:58, Vineet Gupta wrote:
>>>> On 11/01/2013 11:15 AM, Vineet Gupta wrote:
>>>>> +CC Sam, Tim, Joe, Michal, David
>>>>>
>>>>> Guys can you please take a look at this patch and suggest the best way to merge.
>>>>>
>>>>> The root cause is some gas ports (including ARC) use ';' for comment (vs. newline)
>>>>> More background at https://lkml.org/lkml/2013/10/24/365
>>>> Ping ! Any objections to this. Given that this is exception case, it is simpler
>>>> than defining a Kconfig control.
>>>>
>>>> -Vineet
>>>>>
>>>>> On 10/29/2013 07:21 AM, Chen Gang wrote:
>>>>>> For some assemblers, they use another character as newline in a macro
>>>>>> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
>>>>>> macro) instead of ';' for it.
>>>>>>
>>>>>> Also need notice about code styles ('\t' for each line).
>>>>>>
>>>>>>
>>>>>> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> 
>>
>> Did you hit reply by mistake - as I can't seem to find any comments...
> 
> Oops :). I wanted to ask if this is the final patch that should be
> merged, or if there are more known instances of .S code that needs
> s/;/ASM_NL/. I did not find any suspects outside arch/ by grepping. If
> this is the final patch, Chen, could you please resubmit it? I do not
> have the original copy.
> 
> Michal
> 

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/