lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 09 Jan 2014 00:50:54 -0600
From:	Mike Christie <michaelc@...wisc.edu>
To:	open-iscsi@...glegroups.com
CC:	Vaughan Cao <vaughan.cao@...cle.com>, JBottomley@...allels.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iscsi: fix wrong order of opcode and itt in iscsi_handle_reject
 prompt

On 01/08/2014 08:21 PM, Vaughan Cao wrote:
> This patch makes reject messages show right value for opcode and itt, which
> is converse previously.
> 
> Signed-off-by: Vaughan Cao <vaughan.cao@...cle.com>
> ---
>  drivers/scsi/libiscsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index e399561..27547ff 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1013,13 +1013,13 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
>  		iscsi_conn_printk(KERN_ERR, conn,
>  				  "pdu (op 0x%x itt 0x%x) rejected "
>  				  "due to DataDigest error.\n",
> -				  rejected_pdu.itt, opcode);
> +				  opcode, rejected_pdu.itt);
>  		break;
>  	case ISCSI_REASON_IMM_CMD_REJECT:
>  		iscsi_conn_printk(KERN_ERR, conn,
>  				  "pdu (op 0x%x itt 0x%x) rejected. Too many "
>  				  "immediate commands.\n",
> -				  rejected_pdu.itt, opcode);
> +				  opcode, rejected_pdu.itt);
>  		/*
>  		 * We only send one TMF at a time so if the target could not
>  		 * handle it, then it should get fixed (RFC mandates that
> @@ -1059,8 +1059,8 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
>  	default:
>  		iscsi_conn_printk(KERN_ERR, conn,
>  				  "pdu (op 0x%x itt 0x%x) rejected. Reason "
> -				  "code 0x%x\n", rejected_pdu.itt,
> -				  rejected_pdu.opcode, reject->reason);
> +				  "code 0x%x\n", rejected_pdu.opcode,
> +				  rejected_pdu.itt, reject->reason);
>  		break;
>  	}
>  	return rc;
> 

Thanks.

Acked-by: Mike Christie <michaelc@...wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists