linux-kernel - Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9yfHymqqKTdmvV0CcfzKGceQLpJJOnVYUD_GqbwJeqLLJZRA@mail.gmail.com>
Date:	Fri, 10 Jan 2014 11:50:13 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Naveen Krishna Ch <naveenkrishna.ch@...il.com>
Cc:	Tomasz Figa <t.figa@...sung.com>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	linux-crypto@...r.kernel.org,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Vladimir Zapolskiy <vzapolskiy@...il.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Tomasz Figa <tomasz.figa@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

Hi Naveen,

On 10 January 2014 11:37, Naveen Krishna Ch <naveenkrishna.ch@...il.com> wrote:
> Hello Tomasz,
>

[snip]
>>> *pdev)
>>>   static struct platform_driver s5p_aes_crypto = {
>>>         .probe  = s5p_aes_probe,
>>>         .remove = s5p_aes_remove,
>>> +       .id_table       = s5p_sss_ids,
>>>         .driver = {
>>>                 .owner  = THIS_MODULE,
>>>                 .name   = "s5p-secss",
>>> +               .of_match_table = s5p_sss_dt_match,
>>
>>
>> .of_match_table = of_match_ptr(s5p_sss_dt_match),
> I dint use it, Some time back there was a patchset from Sachin
> https://lkml.org/lkml/2013/9/28/61
> Please suggest me on this.

In those cases the structure was always compiled in. i.e., it was not protected
by #ifdef CONFIG_OF. Hence use of of_match_ptr was not required. of_match_ptr
abstracts this check depending on OF is enabled or not. In the case of
this (sss) driver,
since you are using CONFIG_OF to selectively compile out the code (and esp.
s5p_sss_dt_match structure), use of of_match_ptr will make the code
simpler as it
avoids the use of a dummy structure definition (the #else part of the
struct definition) when OF is
disabled. Hope this clarifies.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/