lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jan 2014 15:06:52 +0800 From: Jason Wang <jasowang@...hat.com> To: Stephen Hemminger <stephen@...workplumber.org> CC: "Michael S. Tsirkin" <mst@...hat.com>, John Fastabend <john.fastabend@...il.com>, John Fastabend <john.r.fastabend@...el.com>, Neil Horman <nhorman@...driver.com>, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevic@...hat.com> Subject: Re: [PATCH net 1/2] macvlan: forbid L2 fowarding offload for macvtap On 01/10/2014 05:39 AM, Stephen Hemminger wrote: > On Thu, 09 Jan 2014 16:55:07 +0800 > Jason Wang <jasowang@...hat.com> wrote: > >> What if use do want a qdisc and want to change the its queue length for >> tun/macvlan? And the the name tx_queue_length is misleading. For tun it >> may make sense since it was used in transmission path. For macvtap it >> was not. So maybe what we need is just a new ioctl for both tun/macvtap >> and a new feature flag. If user create the device with new feature flag, >> the socket receive queue length could be changed by ioctl instead of >> dev->tx_queue_length. If not, the old behaviour could be kept. > The overloading of tx_queue_len in macvtap was the original design mistake. > Can't this just be undone and expose rx_queue_len as sysfs attribute? That works. But we current allow user to change the socket sndbuf through TUNSNDBUF. Maybe we need a similar one for receive. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists