linux-kernel - Re: [LNG] [PATCH] ARM: traps: fix opcode endianness when read from user memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAArO44uXBmnz3Cn9n5bBCfw_AHcX2B0OqPZpVzbOT9Nu5sEq2A@mail.gmail.com>
Date:	Fri, 10 Jan 2014 02:38:55 +0200
From:	Taras Kondratiuk <taras.kondratiuk@...aro.org>
To:	Victor Kamensky <victor.kamensky@...aro.org>
Cc:	Russell King <linux@....linux.org.uk>,
	Patch Tracking <patches@...aro.org>,
	Linaro Networking <linaro-networking@...aro.org>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	Ben Dooks <ben.dooks@...ethink.co.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [LNG] [PATCH] ARM: traps: fix opcode endianness when read from
 user memory

I've just put it into tracker with your Reviewed-by.

On 10 January 2014 02:09, Victor Kamensky <victor.kamensky@...aro.org> wrote:
> Taras, it looks good. Did you submit it into Russell's patch system? It
> would be good to have this fix in main line tree.
>
> Anyone, is there any concerns about this patch? It is quite simple
> change.
>
> Thanks,
> Victor
>
> On 23 December 2013 08:42, Taras Kondratiuk <taras.kondratiuk@...aro.org> wrote:
>> Currently code has an inverted logic: opcode from user memory
>> is swapped to a proper endianness only in case of read error.
>> While normally opcode should be swapped only if it was read
>> correctly from user memory.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@...aro.org>
>> ---
>>  arch/arm/kernel/traps.c |    5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
>> index 7940241..36a844e 100644
>> --- a/arch/arm/kernel/traps.c
>> +++ b/arch/arm/kernel/traps.c
>> @@ -425,9 +425,10 @@ asmlinkage void __exception do_undefinstr(struct pt_regs *regs)
>>                         instr2 = __mem_to_opcode_thumb16(instr2);
>>                         instr = __opcode_thumb32_compose(instr, instr2);
>>                 }
>> -       } else if (get_user(instr, (u32 __user *)pc)) {
>> +       } else {
>> +               if (get_user(instr, (u32 __user *)pc))
>> +                       goto die_sig;
>>                 instr = __mem_to_opcode_arm(instr);
>> -               goto die_sig;
>>         }
>>
>>         if (call_undef_hook(regs, instr) == 0)
>> --
>> 1.7.9.5
>>
>> --
>> You received this message because you are subscribed to the Google Groups "Linaro Networking" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to linaro-networking+unsubscribe@...aro.org.
>> To post to this group, send email to linaro-networking@...aro.org.
>
> --
> You received this message because you are subscribed to the Google Groups "Linaro Networking" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linaro-networking+unsubscribe@...aro.org.
> To post to this group, send email to linaro-networking@...aro.org.



-- 
Regards,
Taras Kondratiuk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/