linux-kernel - Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140110094015.GU30234@mwanda>
Date:	Fri, 10 Jan 2014 12:40:15 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	KY Srinivasan <kys@...rosoft.com>
Cc:	"olaf@...fle.de" <olaf@...fle.de>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

On Thu, Jan 09, 2014 at 09:05:05PM +0000, KY Srinivasan wrote:
> > 
> > We've had this discussion before where you urge me to trust the host...
> 
> I am just implementing the protocol specification given by the host. If I cannot trust the
> specified protocol, I am not sure what else can be done here.

I'm sorry I got too upset and we're not communicating correctly.

Anyway, looking at the code, there is actually locking in
process_chn_event() which protect ->fcopy_context.  It's still sucky to
only store the last message in the queue but that's ok.

+static int fcopy_handle_handshake(int op)
+{
+       int ret = 1;
+
+       pr_info("FCP: user-mode registering done.\n");
+       fcopy_transaction.active = false;
+       set_channel_read_state((struct vmbus_channel *)
+                               fcopy_transaction.fcopy_context,
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Dereferenced inside the call to set_channel_read_state()

+                               true);
+
+       if (fcopy_transaction.fcopy_context)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Checked for NULL.

+               hv_fcopy_onchannelcallback(fcopy_transaction.fcopy_context);
+
+       in_hand_shake = false;
+       return ret;
+}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/