linux-kernel - Re: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140110110900.GC29039@sirena.org.uk>
Date:	Fri, 10 Jan 2014 11:09:00 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	lgirdwood@...il.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable
 check

On Fri, Jan 10, 2014 at 10:05:50AM +0800, Xiubo Li wrote:

> +	if (!np || !of_device_is_available(np))
> +		return -ENODEV;
> +

I would expect the of_device_is_available() check to be done by the
driver core rather than by individual drivers - every single driver
should have that check.  Is this not happening?  The check for np is OK
though.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)