linux-kernel - Re: [PATCH v4] video: add OpenCores VGA/LCD framebuffer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jan 2014 14:08:27 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
	<linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>
CC:	<plagnioj@...osoft.com>
Subject: Re: [PATCH v4] video: add OpenCores VGA/LCD framebuffer driver

Hi,

On 2013-11-29 17:45, Stefan Kristiansson wrote:
> This adds support for the VGA/LCD core available from OpenCores:
> http://opencores.org/project,vga_lcd
> 
> The driver have been tested together with both OpenRISC and
> ARM (socfpga) processors.
> 
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>

If I'm not mistaken, this driver has been designed so that there can
only be one VGA/LCD core device on the system.

It would be better to get rid of those static structs, and have the
driver data per device as it should. That way the driver works even with
multiple VGA/LCD cores (although the video mode module option is a bit
odd in that case).

 Tomi

Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)