linux-kernel - Re: [PATCH 2/3] mmc: Add realtek USB sdmmc host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Jan 2014 13:49:02 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	rogerable@...ltek.com
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, Chris Ball <cjb@...top.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Alex Dubov <oakad@...oo.com>, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, driverdev-devel@...uxdriverproject.org,
	wei_wang@...lsil.com.cn, micky_ching@...lsil.com.cn
Subject: Re: [PATCH 2/3] mmc: Add realtek USB sdmmc host driver

On Mon, 2013-12-23 at 17:52 +0800, rogerable@...ltek.com wrote:
> From: Roger Tseng <rogerable@...ltek.com>
> 
> Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
> USB card reader MFD driver.
> 
> Signed-off-by: Roger Tseng <rogerable@...ltek.com>

> +#ifdef DEBUG

Dynamic debugging would be nice.

> +static void sd_print_debug_regs(struct rtsx_usb_sdmmc *host)
> +{
> +	struct rtsx_ucr *ucr = host->ucr;
> +	u8 val = 0;
> +
> +	rtsx_usb_ep0_read_register(ucr, SD_STAT1, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_STAT1: 0x%x\n", val);
> +	rtsx_usb_ep0_read_register(ucr, SD_STAT2, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_STAT2: 0x%x\n", val);
> +	rtsx_usb_ep0_read_register(ucr, SD_BUS_STAT, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_BUS_STAT: 0x%x\n", val);
> +}
> +#else
> +#define sd_print_debug_regs(host)
> +#endif /* DEBUG */
> +


	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/