linux-kernel - Re: [PATCH 2/2] intel_idle: close avn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1676949.y75c76bCzK@vostro.rjw.lan>
Date:	Fri, 10 Jan 2014 14:32:36 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Len Brown <len.brown@...el.com>, Len Brown <lenb@...nel.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] intel_idle: close avn_cstates array with correct marker

On Friday, January 10, 2014 09:59:30 AM Jiang Liu wrote:
> 
> On 2014/1/9 21:31, Rafael J. Wysocki wrote:
> > On Thursday, January 09, 2014 03:30:27 PM Jiang Liu wrote:
> >> Close avn_cstates array with correct marker to avoid overflow
> >> in function intel_idle_cpu_init().
> >>
> >> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
> >> Cc: <stable@...r.kernel.org> # 3.13
> > 
> > Why did you mark it for 3.13-stable?  3.13 hasn't been released yet, so this
> > can be pushed for 3.13 still.
> > 
> > Is the problem present in 3.13-rc?  If so, has it been introduced by any
> > recent commits or was it there before?  In which case, do we need this patch
> > in stable as well?
> > 
> > Rafael
> Hi Rafael,
> 	This issue is introduced in 3.13-rc2, and I feel it's too late
> to catch up with 3.13 window, so mark it for 3.13 speculatively.
> 	After more thoughts, I feel this patch should be divided into
> two patches.
> 	One is to temporarily remove the __initdata marker. The other
> is to correctly mark end of avn_cstates array. The second bug should
> be introduced when merging "22e580d intel_idle: Fixed C6 state on
> Avoton/Rangeley processors" with "eba682a intel_idle: shrink states tables".
> 	Should I split it into two?

No need.  I'm going to push your fixes to Linus shortly.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/