linux-kernel - Re: randconfig build error with next-20140108, in drivers/xen/platform-pci.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52D012D9.1010602@citrix.com>
Date:	Fri, 10 Jan 2014 15:33:45 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Jim Davis <jim.epost@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<boris.ostrovsky@...cle.com>, <xen-devel@...ts.xenproject.org>
Subject: Re: randconfig build error with next-20140108, in drivers/xen/platform-pci.c

On 10/01/14 15:07, Konrad Rzeszutek Wilk wrote:
> On Wed, Jan 08, 2014 at 03:32:00PM -0700, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> drivers/xen/platform-pci.c: In function ‘platform_pci_init’:
>> drivers/xen/platform-pci.c:131:2: error: implicit declaration of
>> function ‘pci_request_region’ [-Werror=implicit-function-declaration]
>>   ret = pci_request_region(pdev, 1, DRV_NAME);
>>   ^
>> drivers/xen/platform-pci.c:170:2: error: implicit declaration of
>> function ‘pci_release_region’ [-Werror=implicit-function-declaration]
>>   pci_release_region(pdev, 0);
>>   ^
>> cc1: some warnings being treated as errors
>> make[2]: *** [drivers/xen/platform-pci.o] Error 1
>>
>> These warnings appeared too:
>>
>> warning: (XEN_PVH) selects XEN_PVHVM which has unmet direct
>> dependencies (HYPERVISOR_GUEST && XEN && PCI && X86_LOCAL_APIC)
> 
> Hey Jim,
> 
> This fix works for me:
> 
> 
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> index d88bfd6..01b9026 100644
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -53,6 +53,5 @@ config XEN_DEBUG_FS
>  
>  config XEN_PVH
>  	bool "Support for running as a PVH guest"
> -	depends on X86_64 && XEN
> -	select XEN_PVHVM
> +	depends on X86_64 && XEN && XEN_PVHVM
>  	def_bool n
> 
> David, you OK with that? You suggested to use 'select' in the patchset
> instead of 'depends' and this throws away your suggestion.

Yes.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/