| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140110023425.GF6780@kernel.dk> Date: Thu, 9 Jan 2014 19:34:25 -0700 From: Jens Axboe <axboe@...nel.dk> To: Christoph Hellwig <hch@...radead.org> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] blk-mq: use __smp_call_function_single directly On Thu, Jan 09 2014, Christoph Hellwig wrote: > On Wed, Jan 08, 2014 at 02:31:15PM -0700, Jens Axboe wrote: > > On 01/08/2014 10:33 AM, Christoph Hellwig wrote: > > > __smp_call_function_single already avoids multiple IPIs by internally > > > queing up the items, and now also is available for non-SMP builds as > > > a trivially correct stub, so there is no need to wrap it. If the > > > additional lock roundtrip cause problems my patch to convert the > > > generic IPI code to llists is waiting to get merged will fix it. > > > > Thanks Christoph, applied it. > > Btw, the same should be done to the null_blk ipi completion > path in theory. But given that it always tries to IPI the local > CPU __smp_call_function_single turns into a simple indirect function > call, so I don't really understand the point of that code path at all. The idea would be to have it forced be remote, on the given CPU, not always just go local. So it just needs to be fixed up, it doesn't make a lot of sense as it stands as a separate completion method. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists