| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <52D07AEC.6060209@oracle.com> Date: Fri, 10 Jan 2014 17:57:48 -0500 From: Boris Ostrovsky <boris.ostrovsky@...cle.com> To: Olaf Hering <olaf@...fle.de> CC: david.vrabel@...rix.com, xen-devel@...ts.xen.org, linux-kernel@...r.kernel.org Subject: Re: [Xen-devel] [PATCH] xen-blkfront: remove type check from blkfront_setup_discard On 01/10/2014 05:49 PM, Olaf Hering wrote: > On Fri, Jan 10, Boris Ostrovsky wrote: > >> I think we should at clear feature_discard and print an error in the log if >> *either* of xenbus_gather() calls fail. > Are you sure about that? AFAIK many other properties are optional as > well. I dont think there is a formal spec about the discard related > properties. Should every backend be required to provide all four > properties? It's not whether the properties are required or not. It's that they may have been set by the admin but we ignored them. I am particularly concerned about security setting. Can you determine from the error whether the call failed or the property wasn't available? Alternatively, we may have to require the toolstack that if feature-discard is provided then all three of these are provided as well. And then you disable discard on any error. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists