linux-kernel - Re: [percpu_counter] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140111124841.00cd5893.akpm@linux-foundation.org>
Date:	Sat, 11 Jan 2014 12:48:41 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	kernel test robot <fengguang.wu@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [percpu_counter] WARNING: CPU: 1 PID: 1 at
 kernel/locking/lockdep.c:3537 check_flags()

On Sun, 12 Jan 2014 00:36:07 +0800 Ming Lei <tom.leiming@...il.com> wrote:

> >
> > [    8.093354] ------------[ cut here ]------------
> > [    8.095469] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check_flags+0x77/0x1ba()
> > [    8.095469] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)
> 
> The warning is caused by the added raw_local_irq_save(), which should
> have been local_irq_save(flags). Actually, it is a false positive.
> 
> Andrew, considered that your approach may be more efficient than this
> one since preempt_disable()/preempt_enable() can be removed too.
> 
> So could you prepare one patch for fixing the problem? Or if you are busy, I'd
> like to do it.

Yes, please send a fresh patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/