lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Jan 2014 03:35:25 +0000 From: "Brown, Aaron F" <aaron.f.brown@...el.com> To: Alexey Khoroshilov <khoroshilov@...ras.ru>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com> CC: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Allan, Bruce W" <bruce.w.allan@...el.com>, "Wyborny, Carolyn" <carolyn.wyborny@...el.com>, "Skidmore, Donald C" <donald.c.skidmore@...el.com>, "Rose, Gregory V" <gregory.v.rose@...el.com>, "Duyck, Alexander H" <alexander.h.duyck@...el.com>, "Ronciak, John" <john.ronciak@...el.com>, "e1000-devel@...ts.sourceforge.net" <e1000-devel@...ts.sourceforge.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org> Subject: RE: [PATCH] e1000: avoid potential deadlock in e1000_do_[read|write]_eeprom() > From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] > On Behalf Of Alexey Khoroshilov > Sent: Friday, December 20, 2013 2:25 PM > To: Kirsher, Jeffrey T > Cc: Alexey Khoroshilov; Brandeburg, Jesse; Allan, Bruce W; Wyborny, > Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H; Ronciak, > John; e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org; linux- > kernel@...r.kernel.org; ldv-project@...uxtesting.org > Subject: [PATCH] e1000: avoid potential deadlock in > e1000_do_[read|write]_eeprom() > > If eeprom->word_size is zero, e1000_do_[read|write]_eeprom() invoke > e1000_init_eeprom_params() to reinit eeprom params. > That is not a good idea since e1000_init_eeprom_params() calls > e1000_read_eeprom() if eeprom->type is e1000_eeprom_spi. > That means a deadlock on e1000_eeprom_lock. > > At the same time it is unclear if the reinit is needed at all. > e1000_init_eeprom_params() is called from probe, so it should succeed > before any activities of the module start. > > The patch suggests to remove the try to reinit eeprom params. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> Signed-off-by: Aaron Brown <aaron.f.brown@...el.com> Tested by: Aaron Brown <aaron.f.brown@...el.com> > --- > drivers/net/ethernet/intel/e1000/e1000_hw.c | 8 -------- > 1 file changed, 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists