linux-kernel - Re: [xfs] c91c46c12: xfstests generic/313 regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140111111045.GA29380@infradead.org>
Date:	Sat, 11 Jan 2014 03:10:45 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeff Liu <jeff.liu@...cle.com>
Cc:	Christoph Hellwig <hch@...radead.org>, fengguang.wu@...el.com,
	LKML <linux-kernel@...r.kernel.org>,
	"xfs@....sgi.com" <xfs@....sgi.com>
Subject: Re: [xfs] c91c46c12: xfstests generic/313 regression

On Fri, Jan 10, 2014 at 10:01:00PM +0800, Jeff Liu wrote:
> I also thought to fix this problem in this way, however I'm not sure
> if those flags can be set back to iattr->ia_valid internally...
> 
> Otherwise, this fix looks good to me.

Nothing in the truncate or open code path (or non-size setattr for that
matter) looks at ia_valid after calling the filesystem, and they really
have no business to.

In the meantime this has passed xfstests, so I'll send it along.  Thanks
for the first fix, btw!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/