linux-kernel - Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFB2WuU=aGwVM7n1Zy7OSnEaR00ZWyPNXGw9A5MBk1p0+LSKZg@mail.gmail.com>
Date:	Sat, 11 Jan 2014 16:56:44 +0530
From:	Monam Agarwal <monamagarwal123@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org,
	Rashika Kheria <rashika.kheria@...il.com>,
	peter.p.waskiewicz.jr@...el.com, andreas.dilger@...el.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor the function
 interval_erase_color() in /lustre/ldlm/interval_tree.c

I took n as a flag to decide whether parent->in_left == node is true
or not in the called function.
Should I use some other name for the flag.

On Sat, Jan 11, 2014 at 4:49 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote:
>> The function interval_erase_color() in lustre/ldlm/interval_tree.c is
>> too long and can be refactored. Most of the statements are same for if
>> and else conditions. I am passing a new variable n based on which the
>> differences are recognised.
>>
>
> "n" stands for number, but what is the it the number of?
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/