linux-kernel - Re: [PATCH] iio: tsl2563: Initialize channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D30BF7.90107@kernel.org>
Date:	Sun, 12 Jan 2014 21:41:11 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Peter Meerwald <pmeerw@...erw.net>
CC:	pali.rohar@...il.com, pavel@....cz, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Ivaylo Dimitrov <freemangordon@....bg>
Subject: Re: [PATCH] iio: tsl2563: Initialize channels



On 12/01/14 21:08, Ivaylo Dimitrov wrote:
> On 12.01.2014 22:55, Peter Meerwald wrote:
>>
>> I think the fix should rather be
>>
>>     if (chan->channel2 == IIO_MOD_LIGHT_BOTH)
>>         chip->calib0 = calib_from_sysfs(val);
>>     else if (chan->channel2 == IIO_MOD_LIGHT_IR)
>>         chip->calib1 = calib_from_sysfs(val);
>>     else
>>         return -EINVAL;
>>
>> since only the INTENSITY channels have a CALIBSCALE info
>>
>> the light channel incorrectly sets .indexed = 1 and .channel = 0 which
>> should be unnecessary since there is only one IIO_LIGHT channel
>>
>> regards, p.
>>
>
> I thought so when I was preparing the patch, but unfortunately couldn't find any documentation for iio subsystem structs and defines, besides what is in the header files (and it is not very descriptive), so I took the easy route.
>
> However, I'll send a new patch with the above (and a little more) changes.
Leave the indexed bit alone.  Whilst unnecessary it is fine within the ABI
and changing it would be a userspace ABI change.

Otherwise, as described by Peter will be fine.

Jonathan
>
> Thanks,
> Ivo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/