linux-kernel - Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D28238.5010903@dev.mellanox.co.il>
Date:	Sun, 12 Jan 2014 13:53:28 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Sagi Grimberg <sagig@...lanox.com>
CC:	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

<SNIP>

>> I wander how we can skip  sbc_dif_verify_xxxx if the transport already
>> offloaded DIF verify.
>> I think that the transport should signal the core layer that it is able
>> to offload DIF (ADD/STRIP/PASS/VERIFY), in which case the core should
>> turn off the backstore DIF verify emulation to sustain performance.
> So IBLOCK + PSCSI backends will need to be a non interleaved protection
> PASS for fast path operation, and backend protection emulation is
> reserved for RAMDISK and perhaps a special FILEIO full emulation mode.

But can't we avoid that if transport already verified? This will kill 
performance.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/