linux-kernel - Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D283B8.6050108@dev.mellanox.co.il>
Date:	Sun, 12 Jan 2014 13:59:52 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Sagi Grimberg <sagig@...lanox.com>
CC:	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	oren Duer <oren@...lanox.com>
Subject: Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb
 for DIF

On 1/10/2014 9:04 AM, Nicholas A. Bellinger wrote:
> On Thu, 2014-01-09 at 16:58 +0200, Sagi Grimberg wrote:
>> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
>>> From: Nicholas Bellinger <nab@...ux-iscsi.org>
>>>
>>> This patch adds sbc_check_prot() for performing various DIF
>>> related CDB sanity checks, along with setting SCF_PROT once
>>> sanity checks have passed.
>>>
>>> Also, add calls in sbc_parse_cdb() for READ_[10,12,16] +
>>> WRITE_[10,12,16] to perform DIF sanity checking.
>>>
>>> Cc: Martin K. Petersen <martin.petersen@...cle.com>
>>> Cc: Christoph Hellwig <hch@....de>
>>> Cc: Hannes Reinecke <hare@...e.de>
>>> Cc: Sagi Grimberg <sagig@...lanox.com>
>>> Cc: Or Gerlitz <ogerlitz@...lanox.com>
>>> Signed-off-by: Nicholas Bellinger <nab@...ux-iscsi.org>
>>> ---
>>>    drivers/target/target_core_sbc.c |   39 ++++++++++++++++++++++++++++++++++++++
>>>    1 file changed, 39 insertions(+)
>>>
>>> diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
>>> index 52ae54e..600ffcb 100644
>>> --- a/drivers/target/target_core_sbc.c
>>> +++ b/drivers/target/target_core_sbc.c
>>> @@ -563,6 +563,27 @@ sbc_compare_and_write(struct se_cmd *cmd)
>>>    	return TCM_NO_SENSE;
>>>    }
>>>    
>>> +bool
>>> +sbc_check_prot(struct se_device *dev, struct se_cmd *cmd, unsigned char *cdb)
>>> +{
>>> +	if (!dev->dev_attrib.pi_prot_type)
>>> +		return true;
>>> +
>>> +	if (dev->dev_attrib.pi_prot_type == TARGET_DIF_TYPE2_PROT &&
>>> +	   (cdb[1] & 0xe0))
>>> +		return false;
>>> +
>>> +	if (!(cdb[1] & 0xe0)) {
>>> +		pr_warn("Target: Unprotected READ/WRITE to DIF device\n");
>>> +		return true;
>>> +	}
>>> +	if (!cmd->t_prot_sg || !cmd->t_prot_nents)
>>> +		return true;
>>> +
>>> +	cmd->se_cmd_flags |= SCF_PROT;
>> Isn't this the place to fill the se_cmd DIF execution parameters?
>> prot_op, prot_type, guard_type, initial_reftag, apptag etc...
>> Next, all parties interested in DIF execution should look in se_cmd
>> (backstore, transport).
> Yes, working on this for -v2 as well.  :)

OK, so just to be clear, both the transport and the backstore will be 
look in se_cmd protection attributes when executing IO correct?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/