linux-kernel - Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D28946.3000202@dev.mellanox.co.il>
Date:	Sun, 12 Jan 2014 14:23:34 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Sagi Grimberg <sagig@...lanox.com>
CC:	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>,
	Oren Duer <oren@...lanox.com>
Subject: Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

On 1/10/2014 11:06 PM, Martin K. Petersen wrote:
>>>>>> "Sagi" == Sagi Grimberg <sagig@...lanox.com> writes:
> Sagi> I wander how we can skip sbc_dif_verify_xxxx if the transport
> Sagi> already offloaded DIF verify.  I think that the transport should
> Sagi> signal the core layer that it is able to offload DIF
> Sagi> (ADD/STRIP/PASS/VERIFY), in which case the core should turn off
> Sagi> the backstore DIF verify emulation to sustain performance.
>
> Yeah, for SAS and FC it would be nice to leverage DIX and let the ASIC
> do the actual checking and splitting. I assume the same is true for your
> hw.
>

Correct! we should avoid a duplicate DIF processing. if the HW supports 
offloading DIF processing, target core can shutdown backstore 
verfy_read/verify_write methods.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/