linux-kernel - Re: [PATCH 09/14] target/configfs: Expose protection device attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq138ktpdz9.fsf@sermon.lab.mkp.net>
Date:	Sun, 12 Jan 2014 07:43:38 -0500
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Sagi Grimberg <sagig@....mellanox.co.il>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Sagi Grimberg <sagig@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: Re: [PATCH 09/14] target/configfs: Expose protection device attributes

>>>>> "Sagi" == Sagi Grimberg <sagig@....mellanox.co.il> writes:

>> The IP checksum is only supported by DIX between OS and initiator,
>> not by the target. I guess we could signal to the initiator via a
>> vendor-private VPD that IP checksum is supported directly. But now
>> what we have hardware-accelerated T10 CRC I don't think it's a big
>> deal.

Sagi> shouldn't it stick around if it is not deprecated yet, the
Sagi> transport is required to support ip-csum->CRC conversion anyhow.

SBC mandates that the guard tag on the wire and on the target device be
the T10 CRC. The IP checksum is a DIX-optimization for application-HBA
exchanges. The only place you should support the IP checksum is in the
initiator.

Note that you could conceivably do a T10 CRC to IP checksum conversion
on writes received by the target and store the IP checksum on disk. And
then convert back to T10 CRC when the data is eventually read. But it
makes no sense to do that given that you will have to do the T10 CRC
calculation regardless. Even if the backing store is DIX-capable and
supports the IP checksum.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/