linux-kernel - Re: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140112171609.GA3773@samfundet.no>
Date:	Sun, 12 Jan 2014 18:16:09 +0100
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Sergei Trofimovich <slyfox@...too.org>
Cc:	linux-kernel@...r.kernel.org, Mark Jackson <mpfj@...c.co.uk>,
	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Subject: Re: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h'
 for MODULE_LICENSE

Around Fri 10 Jan 2014 11:16:14 +0300 or thereabout, Sergei Trofimovich wrote:
> config: make ARCH=avr32 mimc200_defconfig
> 
>> All error/warnings:
>>
>>    arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
>>    arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
>>    arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
>> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype
> 
> Untested.

Looks very sane.

> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> CC: Mark Jackson <mpfj@...c.co.uk>
> CC: Hans-Christian Egtvedt <egtvedt@...fundet.no>
> CC: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
> Signed-off-by: Sergei Trofimovich <slyfox@...too.org>

Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>

> ---
>  arch/avr32/boards/mimc200/fram.c | 1 +
>  1 file changed, 1 insertion(+)

I will append this to the AVR32 tree at git.kernel.org.

> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a..76cb51d 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -13,6 +13,7 @@
>  #include <linux/miscdevice.h>
>  #include <linux/proc_fs.h>
>  #include <linux/mm.h>
> +#include <linux/module.h>
>  #include <linux/io.h>
>  
>  #define FRAM_BASE	0xac000000
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/