[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140113101822.GA5388@pd.tnic>
Date: Mon, 13 Jan 2014 11:18:22 +0100
From: Borislav Petkov <bp@...en8.de>
To: Dave Young <dyoung@...hat.com>
Cc: Linux EFI <linux-efi@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Borislav Petkov <bp@...e.de>,
Arjan van de Ven <arjan@...ux.intel.com>,
Matt Fleming <matt@...sole-pimps.org>,
Matthew Garrett <mjg59@...f.ucam.org>,
"H. Peter Anvin" <hpa@...or.com>, Toshi Kani <toshi.kani@...com>
Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an
arbitrary pagetable
On Mon, Jan 13, 2014 at 01:32:40PM +0800, Dave Young wrote:
> pr_info? This is for debug purpose, maybe pr_debug is better?
I hate pr_debug as it depends on other defines I have to have defined
properly in order just so I get output.
> How about do not limit to only if (pgd) case, instead do something
> like below: set dump_to_dmesg as a module parameter
X86_PTDUMP is not a module.
And even though the idea to make the efi pagetable dumpable with a
kernel cmdline parameter doesn't sound all that bad, I'd like to hold
off on adding yet another efi= cmdline option and only do so until it is
really needed.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists