linux-kernel - Re: [PATCH RESEND] ACPI: Blacklist Win8 OSI for some HP laptop 2013 models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h8uukuneh.wl%tiwai@suse.de>
Date:	Mon, 13 Jan 2014 12:33:26 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Len Brown <lenb@...nel.org>, Oliver Neukum <oneukum@...e.de>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] ACPI: Blacklist Win8 OSI for some HP laptop 2013 models

At Mon, 13 Jan 2014 12:46:31 +0100,
Rafael J. Wysocki wrote:
> 
> On Monday, January 13, 2014 12:14:18 PM Takashi Iwai wrote:
> > The BIOS on recent HP laptops behaves differently with Win8 OSI,
> > e.g. no backlight control and no rfkill are available.  List them in
> > the blacklist as a workaround.
> > 
> > This patch tries to reduce the added items by matching "G1" suffix,
> > e.g. machines are named like "HP ProBook 430 G1".
> > 
> > Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=856294
> > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> > ---
> > 
> > Rafael, could you check this?
> > If the problem were only about the backlight, we could fix differenly,
> > but BIOS on these machines seems to switching more other functions
> > like rfkill.
> 
> It looks like I have this patch in my linux-next branch.

OK, thanks!


Takashi

> 
> Thanks!
> 
> 
> >  drivers/acpi/blacklist.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> > index 078c4f7fe2dd..40c91f5052ef 100644
> > --- a/drivers/acpi/blacklist.c
> > +++ b/drivers/acpi/blacklist.c
> > @@ -323,6 +323,56 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
> >  		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
> >  		},
> >  	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ProBook 2013 models",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP EliteBook 2013 models",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ZBook 14",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ZBook 15",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ZBook 17",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP EliteBook 8780w",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
> > +		},
> > +	},
> >  
> >  	/*
> >  	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
> > 
> 
> -- 
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/