linux-kernel - Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140113163735.43c1d19b@armhf>
Date:	Mon, 13 Jan 2014 16:37:35 +0100
From:	Jean-Francois Moine <moinejf@...e.fr>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	dri-devel@...ts.freedesktop.org, Rob Clark <robdclark@...il.com>,
	Dave Airlie <airlied@...il.com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in
 range 0..3

On Sat, 11 Jan 2014 18:26:02 +0000
Russell King - ARM Linux <linux@....linux.org.uk> wrote:

> >  	div = 148500 / mode->clock;
> > +	if (div != 0) {
> > +		div--;
> > +		if (div > 3)
> > +			div = 3;
> > +	}  
> 
> As the driver currently stands, we know that the clock divider works for
> the lower resolution modes.  So, as things stand, for 74.25MHz modes,
> we get a divisor of one.
> 
> Your patch changes this, the divider becomes zero.  I wonder whether
> you've tested 720p modes at all with this?

In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode
works fine.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/