linux-kernel - Re: [PATCH v4 1/2] ARM: imx: add select on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACUGKYMx_o6TLsvMxK3Gb+cmOUCX3Toj+6MeJmo=ahfyc=vXCA@mail.gmail.com>
Date:	Sun, 12 Jan 2014 20:54:18 -0800
From:	John Tobias <john.tobias.ph@...il.com>
To:	Shawn Guo <shawn.guo@...aro.org>
Cc:	rjw@...ysocki.net, Viresh Kumar <viresh.kumar@...aro.org>,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<kernel@...gutronix.de>" <kernel@...gutronix.de>,
	"<linux@....linux.org.uk>" <linux@....linux.org.uk>,
	"<linux-arm-kernel@...ts.infradead.org>" 
	<linux-arm-kernel@...ts.infradead.org>,
	Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH v4 1/2] ARM: imx: add select on ARCH_MXC for cpufreq support

I tested leaving the HAVE_IMX_ANATOP under SOC_IMX6Q and SOC_IMX6SL.
The iMX6Q cpufreq driver won't show up in menu config / gconfig and
that's the reason why I added it.

Regards,

john

On Sun, Jan 12, 2014 at 7:20 PM, Shawn Guo <shawn.guo@...aro.org> wrote:
> On Thu, Jan 09, 2014 at 06:39:51PM -0800, John Tobias wrote:
>> Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that
>> the user can enable the cpufreq support for iMX6Q and/or iMX6SL.
>
> All I was asking is to move the following:
>
>         select ARCH_HAS_CPUFREQ
>         select ARCH_HAS_OPP
>         select PM_OPP if PM
>
> So leave HAVE_IMX_ANATOP out there, and only move the above ones please.
>
> Shawn
>
>>
>> Signed-off-by: John Tobias <john.tobias.ph@...il.com>
>> ---
>>  arch/arm/mach-imx/Kconfig | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index 7a6e6f7..d6aa34d 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -1,5 +1,6 @@
>>  config ARCH_MXC
>>       bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
>> +     select ARCH_HAS_CPUFREQ
>>       select ARCH_REQUIRE_GPIOLIB
>>       select ARM_CPU_SUSPEND if PM
>>       select ARM_PATCH_PHYS_VIRT
>> @@ -9,8 +10,10 @@ config ARCH_MXC
>>       select GENERIC_ALLOCATOR
>>       select GENERIC_CLOCKEVENTS
>>       select GENERIC_IRQ_CHIP
>> +     select HAVE_IMX_ANATOP if SOC_IMX6Q || SOC_IMX6SL
>>       select MIGHT_HAVE_CACHE_L2X0 if ARCH_MULTI_V6_V7
>>       select MULTI_IRQ_HANDLER
>> +     select PM_OPP if PM
>>       select SOC_BUS
>>       select SPARSE_IRQ
>>       select USE_OF
>> @@ -779,16 +782,14 @@ config  SOC_IMX53
>>
>>  config SOC_IMX6Q
>>       bool "i.MX6 Quad/DualLite support"
>> -     select ARCH_HAS_CPUFREQ
>> -     select ARCH_HAS_OPP
>> +     select ARCH_HAS_OPP
>>       select ARM_ERRATA_754322
>>       select ARM_ERRATA_764369 if SMP
>>       select ARM_ERRATA_775420
>>       select ARM_GIC
>>       select CPU_V7
>>       select HAVE_ARM_SCU if SMP
>> -     select HAVE_ARM_TWD if SMP
>> -     select HAVE_IMX_ANATOP
>> +     select HAVE_ARM_TWD if SMP
>>       select HAVE_IMX_GPC
>>       select HAVE_IMX_MMDC
>>       select HAVE_IMX_SRC
>> @@ -800,8 +801,7 @@ config SOC_IMX6Q
>>       select PINCTRL_IMX6Q
>>       select PL310_ERRATA_588369 if CACHE_PL310
>>       select PL310_ERRATA_727915 if CACHE_PL310
>> -     select PL310_ERRATA_769419 if CACHE_PL310
>> -     select PM_OPP if PM
>> +     select PL310_ERRATA_769419 if CACHE_PL310
>>
>>       help
>>         This enables support for Freescale i.MX6 Quad processor.
>> @@ -812,7 +812,6 @@ config SOC_IMX6SL
>>       select ARM_ERRATA_775420
>>       select ARM_GIC
>>       select CPU_V7
>> -     select HAVE_IMX_ANATOP
>>       select HAVE_IMX_GPC
>>       select HAVE_IMX_MMDC
>>       select HAVE_IMX_SRC
>> --
>> 1.8.3.2
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/