linux-kernel - Re: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140113161039.GA29039@sirena.org.uk>
Date:	Mon, 13 Jan 2014 16:10:39 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
Cc:	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable
 check

On Mon, Jan 13, 2014 at 06:15:24AM +0000, Li.Xiubo@...escale.com wrote:

> > I would expect the of_device_is_available() check to be done by the
> > driver core rather than by individual drivers - every single driver
> > should have that check.  Is this not happening?  The check for np is OK
> > though.

> Yes, I hasn't found the core driver does that for now...

Are you sure, we actively use the ability to mark devices as unavailable
on some systems?

> And IMO this is needed since the SAI driver is only base dts. And maybe
> the device is not presently operational, but it might become operational
> in the future (for example, something is not plugged in, or switched off).
> Or A serious error was detected in the device, and it is unlikely to become
> operational without repair...

I'm sorry but I don't understand what you're saying here at all.  These
are all things that might happen but I don't see the connection between
them and the benefits of implementing things in the core - surely the
more functionality there is the more useful it's going to be to factor
all the code out into the driver core?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)