linux-kernel - Re: [PATCH 1/1] lockdep: Kill held_lock->check and "int check" arg of __lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140113162040.GB7616@redhat.com>
Date:	Mon, 13 Jan 2014 17:20:40 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Dave Jones <davej@...hat.com>, Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 1/1] lockdep: Kill held_lock->check and "int check" arg
	of __lock_acquire()

On 01/12, Dave Jones wrote:
>
> On Sun, Jan 12, 2014 at 06:45:54PM +0100, Oleg Nesterov wrote:
>
>  > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
>  > index 92b1bfc..13bd13d 100644
>  > --- a/include/linux/lockdep.h
>  > +++ b/include/linux/lockdep.h
>  > @@ -252,7 +252,6 @@ struct held_lock {
>  >  	unsigned int trylock:1;						/* 16 bits */
>  >
>  >  	unsigned int read:2;        /* see lock_acquire() comment */
>  > -	unsigned int check:2;       /* see lock_acquire() comment */
>  >  	unsigned int hardirqs_off:1;
>  >  	unsigned int references:11;					/* 32 bits */
>
> The 'bits' comments seem to be crap, even before your patch.

Hmm, I didn't even notice them.

I think the comments were correct, note that the previous field is uint:13.

But after (with) this patch the width of "references" should be updated.

Thanks,

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/