lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2014 06:23:36 +0000 From: Ben Dooks <ben.dooks@...ethink.co.uk> To: Simon Horman <horms@...ge.net.au> CC: linux-kernel@...ts.codethink.co.uk, Linux Kernel list <linux-kernel@...r.kernel.org>, Linus SH list <linux-sh@...r.kernel.org>, Magnus Damm <magnus.damm@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI On 13/01/14 00:30, Simon Horman wrote: > On Fri, Jan 10, 2014 at 03:18:15PM +0000, Ben Dooks wrote: >> If the kernel is built to support multi-arm configurmation with shmobile >> support built in, then the drivers/sh is not built. This contains drivers >> that are essential to devices support by that configuration, including the >> PM runtime code in drivers/sh/pm_runtime.c (which implicitly enables the >> bus clocks for all devices). >> >> If CONFIG_ARCH_SHMOBILE_MULTI then build the drivers/sh directory, >> but ensure that bits that may conflict (drivers/sh/clk if the common >> clock framework is not enabled) are built. >> >> The ARCH_SHMOBILE_MULTI was added by efacfce5f8a ("ARM: shmobile: Introduce >> ARCH_SHMOBILE_MULTI") but this has only just recently been found due to >> building device-tree only kernels. >> >> Cc: Linux Kernel list <linux-kernel@...r.kernel.org> >> Cc: Linus SH list <linux-sh@...r.kernel.org> >> Cc: Simon Horman <horms@...ge.net.au> >> Cc: Magnus Damm <magnus.damm@...il.com> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> >> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk> >> --- >> drivers/Makefile | 1 + >> drivers/sh/Makefile | 3 +++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/Makefile b/drivers/Makefile >> index 8e3b8b0..abc4744 100644 >> --- a/drivers/Makefile >> +++ b/drivers/Makefile >> @@ -118,6 +118,7 @@ obj-$(CONFIG_SGI_SN) += sn/ >> obj-y += firmware/ >> obj-$(CONFIG_CRYPTO) += crypto/ >> obj-$(CONFIG_SUPERH) += sh/ >> +obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += sh/ >> obj-$(CONFIG_ARCH_SHMOBILE_LEGACY) += sh/ > > Can't we just do the following? I think this is probably a better fix. I am wondering what the original logic of not doing this was. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists