lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2014 11:54:41 -0500 From: Don Zickus <dzickus@...hat.com> To: Gaurav Jain <gjain@...com> Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>, Paul Mackerras <paulus@...ba.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Arun Sharma <asharma@...com> Subject: Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: > Anon records usually do not have the 'execname' entry. However if they are on > the heap, the execname shows up as '[heap]'. The fix considers any executable > entries in the map that do not have a name or are on the heap as anon records > and sets the name to '//anon'. > > This fixes JIT profiling for records on the heap. I guess I don't understand the need for this fix. It seems breaking out //anon vs. [heap] would be useful. Your patch is saying otherwise. Can give a description of the problem you are trying to solve? Also style issue below.. > > Signed-off-by: Gaurav Jain <gjain@...com> > Cc: Ingo Molnar <mingo@...nel.org> > Cc: Jiri Olsa <jolsa@...hat.com> > Cc: Paul Mackerras <paulus@...ba.org> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> > Cc: Don Zickus <dzickus@...hat.com> > Cc: Arun Sharma <asharma@...com> > --- > tools/perf/util/event.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c > index bb788c1..ae9c55b 100644 > --- a/tools/perf/util/event.c > +++ b/tools/perf/util/event.c > @@ -224,10 +224,9 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool, > continue; > > event->header.misc |= PERF_RECORD_MISC_MMAP_DATA; > - } > - > - if (!strcmp(execname, "")) > + } if (!strcmp(execname, "") || !strcmp(execname, "[heap]")) { The '} if' part should seperate the 'if' on to its own line (unless you meant an 'else' in there). Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists