lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2014 10:02:39 -0700 From: Stephen Warren <swarren@...dotorg.org> To: Andrew Bresticker <abrestic@...omium.org>, Linus Walleij <linus.walleij@...aro.org> CC: Thierry Reding <thierry.reding@...il.com>, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] pinctrl: tegra1x4: initialize at arch_initcall time On 01/10/2014 05:50 PM, Andrew Bresticker wrote: > Many devices rely on pinctrl/pinmux settings being applied > before probing and some of these may probe before device_initcall > time (e.g. i2c at subsys_initcall). Move Tegra1x4 pinctrl driver > registration to arch_initcall time so that proper pin settings > can be applied earlier. NAK. We shouldn't play games with initcall levels to achieve probe ordering. It's not scalable and there's no actual guarantee it'll produce the desired result. Instead, if one device depends on another, it should do so explicitly. In other words, the device that relies on a particular pinctrl setting should have a pinctrl state defined, that references the pin controller, which then triggers deferred probe until the pin controller is initialized. Since we initialize the whole pinctrl setup in one go in a state associated with the pin controller, rather than as separate states associated with each device, you'll need to have the leaf devices reference an empty pinctrl state defined in the desired pin controller. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists