linux-kernel - Re: [PATCH 1/2] rwsem: add rwsem_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52D43F26.4040007@fb.com>
Date:	Mon, 13 Jan 2014 14:31:50 -0500
From:	Josef Bacik <jbacik@...com>
To:	Ingo Molnar <mingo@...nel.org>, Chris Mason <clm@...com>
CC:	<linux-kernel@...r.kernel.org>, <peterz@...radead.org>
Subject: Re: [PATCH 1/2] rwsem: add rwsem_is_contended

On 01/13/2014 02:02 PM, Ingo Molnar wrote:
> * Josef Bacik <jbacik@...com> wrote:
>
>> From: Josef Bacik <jbacik@...ionio.com>
>>
>> Btrfs needs a simple way to know if it needs to let go of it's read lock on a
>> rwsem.  Introduce rwsem_is_contended to check to see if there are any waiters on
>> this rwsem currently.  This is just a hueristic, it is meant to be light and not
>> 100% accurate and called by somebody already holding on to the rwsem in either
>> read or write.  Thanks,
>>
>> Signed-off-by: Josef Bacik <jbacik@...ionio.com>
>> ---
>>   include/linux/rwsem.h | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
>> index 0616ffe..03f3b05 100644
>> --- a/include/linux/rwsem.h
>> +++ b/include/linux/rwsem.h
>> @@ -75,6 +75,17 @@ do {								\
>>   } while (0)
>>   
>>   /*
>> + * This is the same regardless of which rwsem implementation that is being used.
>> + * It is just a heuristic meant to be called by somebody alreadying holding the
>> + * rwsem to see if somebody from an incompatible type is wanting access to the
>> + * lock.
>> + */
>> +static inline int rwsem_is_contended(struct rw_semaphore *sem)
>> +{
>> +	return !list_empty(&sem->wait_list);
>> +}
>> +
>> +/*
>>    * lock for reading
>>    */
>>   extern void down_read(struct rw_semaphore *sem);
> Looks good to me. To make it easier to merge 2/2 feel free to add this
> to the BTRFS tree, with my Acked-by:
>
>    Acked-by: Ingo Molnar <mingo@...nel.org>
Great thanks Ingo,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/