linux-kernel - Re: [PATCH] staging: comedi: das1800: Fixing foo * bar should be foo *bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140113235205.GA22441@kroah.com>
Date:	Mon, 13 Jan 2014 15:52:05 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Joe Borg <cyborg101010@...il.com>
Cc:	abbotti@....co.uk, hsweeten@...ionengravers.com,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: das1800: Fixing foo * bar should be foo
 *bar

On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
> *bar' in the parameters of function munge_data().
> 
> Signed-off-by: Joe Borg <cyborg101010@...il.com>
> ---
>  drivers/staging/comedi/drivers/das1800.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
> index 1880038..8fb87df 100644
> --- a/drivers/staging/comedi/drivers/das1800.c
> +++ b/drivers/staging/comedi/drivers/das1800.c
> @@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
>  	return sample;
>  }
>  
> -static void munge_data(struct comedi_device *dev, uint16_t * array,
> +static void munge_data(struct comedi_device *dev, uint16_t *array,
>  		       unsigned int num_elements)

Ok, after all that work, it turns out I can't even apply this patch as
someone else did it already a while ago.  You should be working off of
linux-next, or my staging.git tree, not Linus's tree, as that does not
contain all of the work we are doing on the next version of linux (hence
the -next).

So, care to try again with a different fix?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/