linux-kernel - Re: bug in sscanf()?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140114025230.GT10323@ZenIV.linux.org.uk>
Date:	Tue, 14 Jan 2014 02:52:30 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jan Beulich <JBeulich@...e.com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: bug in sscanf()?

On Tue, Jan 14, 2014 at 02:47:26AM +0000, Al Viro wrote:
> have now.  Something like [completely untested]

And untested it certainly is - at least three missing breaks in there:

> 		case 'H':
> 			STORE(signed char, unsigned char);
> 			break;
> 		case 'h':
> 			STORE(short, unsigned short);
> 			break;
> 		case 'l':
> 			STORE(long, unsigned long);
			break;
> 		case 'L':
> 		case 'j':
> 			STORE(long long, unsigned long long);
			break;
> 		case 'z':
> 		case 'Z':
> 			STORE(long, size_t);
			break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/