linux-kernel - Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871u0bgiai.wl%kuninori.morimoto.gx@gmail.com>
Date:	Mon, 13 Jan 2014 22:59:52 -0800 (PST)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	<broonie@...nel.org>, <lgirdwood@...il.com>, <moinejf@...e.fr>,
	<kuninori.morimoto.gx@...esas.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add	asoc_simple_card_data for the simple card driver data


Hi Xiubo

Thank you for your patch

> Whether the dt is used or not, almost all the simple card information
> for the DAI link and sound card are initialized in the simple card driver.
> 
> And for the platform caller, the snd_link and snd_card are of no use, so
> move them from struct asoc_simple_card_info to struct asoc_simple_card_data.
> 
> And now only one DAI link is supported for simple card.
> 
> Suggested-by: Jean-Francois Moine <moinejf@...e.fr>
> Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
> ---

This patch seems have many this kind of lines
  -	info->xxx
  +	sdata->info->xxx

But, how about add this line to each function ?

     struct asoc_simple_card_info *info = &sdata->info;

Patch will be more readable

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/