linux-kernel - Re: [PATCH 1/7] sched: allow try_to_wake_up to be used internally outside of core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D4F6BA.9010802@canonical.com>
Date:	Tue, 14 Jan 2014 09:35:06 +0100
From:	Maarten Lankhorst <maarten.lankhorst@...onical.com>
To:	Colin Cross <ccross@...gle.com>
CC:	lkml <linux-kernel@...r.kernel.org>,
	"open list:GENERIC INCLUDE/A..." <linux-arch@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	robdclark@...il.com,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	daniel@...ll.ch, Sumit Semwal <sumit.semwal@...aro.org>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 1/7] sched: allow try_to_wake_up to be used internally
 outside of core.c

op 13-01-14 19:50, Colin Cross schreef:
> On Mon, Jan 13, 2014 at 4:31 AM, Maarten Lankhorst
> <maarten.lankhorst@...onical.com> wrote:
>> The kernel fence implementation doesn't use event queues, but needs
>> to perform the same wake up. The symbol is not exported, since the
>> fence implementation is not built as a module.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...onical.com>
>> ---
>>  include/linux/wait.h |    1 +
>>  kernel/sched/core.c  |    2 +-
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/wait.h b/include/linux/wait.h
>> index eaa00b10abaa..c54e3ef50134 100644
>> --- a/include/linux/wait.h
>> +++ b/include/linux/wait.h
>> @@ -12,6 +12,7 @@
>>  typedef struct __wait_queue wait_queue_t;
>>  typedef int (*wait_queue_func_t)(wait_queue_t *wait, unsigned mode, int flags, void *key);
>>  int default_wake_function(wait_queue_t *wait, unsigned mode, int flags, void *key);
>> +int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags);
>>
>>  struct __wait_queue {
>>         unsigned int            flags;
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index a88f4a485c5e..f41d317042dd 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -1578,7 +1578,7 @@ static void ttwu_queue(struct task_struct *p, int cpu)
>>   * Return: %true if @p was woken up, %false if it was already running.
>>   * or @state didn't match @p's state.
>>   */
>> -static int
>> +int
>>  try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
>>  {
>>         unsigned long flags;
>>
> wake_up_state is already available in linux/sched.h, can you use that?
>
Indeed! Thanks for the catch.

~Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/