linux-kernel - Re: [PATCH] Staging: comedi: remove unnecessary braces in pcl711.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52D52478.3060706@mev.co.uk>
Date:	Tue, 14 Jan 2014 11:50:16 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Chase Southwood <chase.southwood@...oo.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	Ian Abbott <ian.abbott@....co.uk>,
	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] Staging: comedi: remove unnecessary braces in pcl711.c

On 2014-01-14 03:13, Chase Southwood wrote:
> This patch for pcl711.c removes braces causing a checkpatch.pl warning.
> It also removes an empty else arm of an if-else statement.
>
> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> ---
>
> I removed the "else" arm of this statement because it was empty, save for the "ignore" comment.  If it is instead preferred kernel style for this empty else to remain in, let me know and I will correct this patch accordingly.
>
>   drivers/staging/comedi/drivers/pcl711.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl711.c b/drivers/staging/comedi/drivers/pcl711.c
> index f0fc123..6595788 100644
> --- a/drivers/staging/comedi/drivers/pcl711.c
> +++ b/drivers/staging/comedi/drivers/pcl711.c
> @@ -336,11 +336,8 @@ static int pcl711_ai_cmdtest(struct comedi_device *dev,
>   	err |= cfc_check_trigger_arg_is(&cmd->convert_arg, 0);
>   	err |= cfc_check_trigger_arg_is(&cmd->scan_end_arg, cmd->chanlist_len);
>
> -	if (cmd->stop_src == TRIG_NONE) {
> +	if (cmd->stop_src == TRIG_NONE)
>   		err |= cfc_check_trigger_arg_is(&cmd->stop_arg, 0);
> -	} else {
> -		/* ignore */
> -	}
>
>   	if (err)
>   		return 3;
>

Not sure if it's worth me reviewing these minor clean-up patches or not, 
but FWIW I approve of this patch.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/