linux-kernel - Re: [PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Jan 2014 14:39:45 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Mike Travis <travis@....com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Jason Wessel <jason.wessel@...driver.com>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hedi Berriche <hedi@....com>, Russ Anderson <rja@....com>,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems

On Tue, Jan 14, 2014 at 05:27:46AM -0800, Mike Travis wrote:
> 
> 
> On 1/14/2014 3:00 AM, Peter Zijlstra wrote:
> > On Mon, Jan 13, 2014 at 10:24:09PM -0600, Mike Travis wrote:
> >> Fix some problems found by the kbuild test robot.
> >>
> >> Signed-off-by: Mike Travis <travis@....com>
> >> Reviewed-by: Hedi Berriche <hedi@....com>
> > 
> > In general it is best to actually mention the issues the patch cures,
> > otherwise review is impossible, /me stares hard at Hedi.
> > 
> 
> I can send an updated patch if required?  The issues were
> pretty trivial so I didn't think more info than the patch
> itself was needed.

It makes it impossible to say if what you did corresponds with what you
meant to do; let alone say if its the 'correct' way.

> Hopefully I don't get a lot more in the future (this was my
> first time), should I include the actual tipbot messages?

Sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/