linux-kernel - Re: [PATCH] ASoC: simple-card: simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140114142014.GM15567@sirena.org.uk>
Date:	Tue, 14 Jan 2014 14:20:14 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	lgirdwood@...il.com, Xiubo Li <Li.Xiubo@...escale.com>,
	alsa-devel@...a-project.org, kuninori.morimoto.gx@...esas.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: simplify code

On Tue, Jan 14, 2014 at 12:36:06PM +0100, Jean-Francois Moine wrote:
> This patch
> - removes the fields of the platform data which are of no use to the
>   non-DT platform callers,
> - uses a new private structure to handle all the sound card information,
> - simplifies the code and make easier a possible multi-DAI links extension.
> 
> Signed-off-by: Jean-Francois Moine <moinejf@...e.fr>
> ---
> Xiubo, I also removed 'of_device_is_available' which seems really
> useless: the module is not probed when the DT status is not "okay".

Please send this as a patch series to aid review, one patch doing four
different changes is much harder to review.

>  		ret = asoc_simple_card_sub_parse_of(np,
> -						  &info->cpu_dai,
> -						  of_cpu);
> +						  &priv->cpu_dai,
> +					  (struct device_node **)
> +						  &dai_link->cpu_of_node,
> +						  &dai_link->cpu_dai_name);


What's this cast here for?  That code doesn't look at all safe.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)