linux-kernel - Re: [PATCH] i2c: Re-instate body of i2c_parent_is_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140114161254.GA6442@katana>
Date:	Tue, 14 Jan 2014 17:12:54 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dia.com>,
	Phil Carmody <phil.carmody@...tner.samsung.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] i2c: Re-instate body of i2c_parent_is_i2c_adapter()

On Mon, Jan 13, 2014 at 02:29:04PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@...dia.com>
> 
> The body of i2c_parent_is_i2c_adapter() is currently guarded by
> CONFIG_I2C_MUX instead.

This paragraph sounds strange to me. I'll update it a little. After that
I'll go looking for a brown paper bag...

> Among potentially other problems, this resulted in i2c_lock_adapter()
> only locking I2C mux child adapters, and not the parent adapter. In
> turn, this could allow inter-mingling of mux child selection and I2C
> transactions, which could result in I2C transactions being directed to
> the wrong I2C bus, and possibly even switching between busses in the
> middle of a transaction.
> 
> One concrete issue caused by this bug was corrupted HDMI EDID reads
> during boot on the NVIDIA Tegra Seaboard system, although this only
> became apparent in recent linux-next, when the boot timing was changed
> just enough to trigger the race condition.
> 
> Fixes: 3923172b3d70 ("i2c: reduce parent checking to a NOOP in non-I2C_MUX case")
> Cc: Phil Carmody <phil.carmody@...tner.samsung.com>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Stephen Warren <swarren@...dia.com>

Applied to for-current, thanks for catching this one!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)