linux-kernel - Re: [PATCH] x86, CPU, AMD: Add workaround for family 16h, erratum 793

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D56627.9060802@zytor.com>
Date:	Tue, 14 Jan 2014 08:30:31 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	Henrique de Moraes Holschuh <hmh@....eng.br>,
	X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Kim Naru <kim.naru@....com>,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>,
	Sherry Hurwitz <sherry.hurwitz@....com>
Subject: Re: [PATCH] x86, CPU, AMD: Add workaround for family 16h, erratum
 793

On 01/14/2014 08:27 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> This adds the workaround for erratum 793 as a precaution in case not
> every BIOS implements it. This addresses CVE-2013-6885.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>

> +
> +#define MSR_AMD_LS_CFG	0xc0011020
> +	/* F16h, models 00h-0fh, erratum 793 */
> +	if (c->x86 == 0x16 && c->x86_model <= 0xf) {

Please put MSR_AMD_LS_CFG in msr-index.h or at least at the top of the
file, and put the CVE reference in the comment.

Otherwise, looks good.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/