linux-kernel - Re: [slub] WARNING: CPU: 0 PID: 0 at mm/slub.c:1511 __kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1401141634580.3375@chino.kir.corp.google.com>
Date:	Tue, 14 Jan 2014 16:36:43 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Dave Hansen <dave.hansen@...el.com>
cc:	Fengguang Wu <fengguang.wu@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Pekka Enberg <penberg@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [slub] WARNING: CPU: 0 PID: 0 at mm/slub.c:1511
 __kmem_cache_create()

On Tue, 14 Jan 2014, Dave Hansen wrote:

> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c65c1877bd6826ce0d9713d76e30a7bed8e49f38
> 
> I think the assert is just bogus at least in the early case.
> early_kmem_cache_node_alloc() says:
>  * No kmalloc_node yet so do it by hand. We know that this is the first
>  * slab on the node for this slabcache. There are no concurrent accesses
>  * possible.
> 
> Should we do something like the attached patch?  (very lightly tested)
> 

Yeah, I think that's the best option to keep the runtime checking to 
ensure the proper lock is held on debug kernels with lockdep enabled and 
is better than reverting back to the comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/