linux-kernel - Re: [PATCH] misc: sram: cleanup the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Jan 2014 10:36:31 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	arnd@...db.de, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: sram: cleanup the code

Am Mittwoch, den 15.01.2014, 11:16 +0800 schrieb Xiubo Li:
> Since the devm_gen_pool_create() is used, so the gen_pool_destroy()
> here is redundant.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
> ---
>  drivers/misc/sram.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
> index afe66571..e3e421d 100644
> --- a/drivers/misc/sram.c
> +++ b/drivers/misc/sram.c
> @@ -87,8 +87,6 @@ static int sram_remove(struct platform_device *pdev)
>  	if (gen_pool_avail(sram->pool) < gen_pool_size(sram->pool))
>  		dev_dbg(&pdev->dev, "removed while SRAM allocated\n");
>  
> -	gen_pool_destroy(sram->pool);
> -
>  	if (sram->clk)
>  		clk_disable_unprepare(sram->clk);
>  

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

thanks
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/