linux-kernel - Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Jan 2014 18:24:01 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Kevin Hilman <khilman@...aro.org>,
	Santosh Shilimkar <santosh.shilimkar@...com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource

On Wednesday 15 January 2014 02:58 PM, Linus Walleij wrote:
> On Tue, Jan 14, 2014 at 12:58 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
> 
>> devm_ioremap_resource does sanity checks on the given resource. No need to
>> duplicate this in the driver.
>>
>> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
>> ---
>>
>> Should go via subsystem tree
>>
>>  drivers/gpio/gpio-davinci.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 84be701..a5e1a56 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>>         }
>>
>>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -       if (!res) {
>> -               dev_err(dev, "Invalid memory resource\n");
>> -               return -EBUSY;
>> -       }
>> -
>>         gpio_base = devm_ioremap_resource(dev, res);
>>         if (IS_ERR(gpio_base))
>>                 return PTR_ERR(gpio_base);
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> The DaVinci maintainers are queuing GPIO patches for their driver
> for this merge window, so requesting them to apply this patch.

I wont be sending any more pull requests for v3.14. Even if I send, the
ARM-SoC maintainers will not take it anyway. So likely this wont get
into v3.14. For v3.15, Linus should be able to queue it as dependencies
would have made it into the kernel by then.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/