linux-kernel - Re: [PATCH v6 3/8] x86: add generic function to modify more calls using int3 framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140115091149.7525db07@gandalf.local.home>
Date:	Wed, 15 Jan 2014 09:11:49 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Petr Mladek <pmladek@...e.cz>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH v6 3/8] x86: add generic function to modify more calls
 using int3 framework

On Wed, 15 Jan 2014 17:18:01 +0900
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:

  
> >> +static char bp_int3;
> > 
> > bp_int3 is not going to be anything but 0xcc. Let's change that to:
> > 
> > static char bp_int3 = 0xcc;
> > 
> > And remove the other initializations.
> 
> just a comment.
> If it is always 0xcc, it should be a const variable.
> 

Yeah, I was thinking that too. As long as sizeof(bp_int3) still works,
which it should for just adding a "const", and not make it a macro.

static const bp_int3 = 0xcc;

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/