linux-kernel - Re: [PATCH 08/17] tools lib traceevent: Unregister handler when function plugin unloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140115112116.21fe7f31@gandalf.local.home>
Date:	Wed, 15 Jan 2014 11:21:16 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH 08/17] tools lib traceevent: Unregister handler when
 function plugin unloaded

On Wed, 15 Jan 2014 10:45:31 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> The function handler should be unregistered when the plugin unloaded
> otherwise it'll try to access invalid memory.
> 
> Cc: Jiri Olsa <jolsa@...hat.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


> ---
>  tools/lib/traceevent/plugin_function.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/lib/traceevent/plugin_function.c b/tools/lib/traceevent/plugin_function.c
> index 39461485f9a7..80ba4ff1fe84 100644
> --- a/tools/lib/traceevent/plugin_function.c
> +++ b/tools/lib/traceevent/plugin_function.c
> @@ -148,6 +148,9 @@ void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent)
>  {
>  	int i, x;
>  
> +	pevent_unregister_event_handler(pevent, -1, "ftrace", "function",
> +					function_handler, NULL);
> +
>  	for (i = 0; i <= cpus; i++) {
>  		for (x = 0; x < fstack[i].size && fstack[i].stack[x]; x++)
>  			free(fstack[i].stack[x]);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/