linux-kernel - Re: [PATCH v4 07/16] ARM: Remove use of struct kprobe from generic probes code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52D6BADC.2040607@linaro.org>
Date:	Wed, 15 Jan 2014 11:44:12 -0500
From:	David Long <dave.long@...aro.org>
To:	"Jon Medhurst (Tixy)" <tixy@...aro.org>
CC:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Rabin Vincent <rabin@....in>, Oleg Nesterov <oleg@...hat.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	davem@...emloft.net, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 07/16] ARM: Remove use of struct kprobe from generic
 probes code

On 12/20/13 08:55, Jon Medhurst (Tixy) wrote:
> On Sun, 2013-12-15 at 23:08 -0500, David Long wrote:
>> From: "David A. Long" <dave.long@...aro.org>
>>
>> Change the generic ARM probes code to pass in the opcode and architecture-specific
>> structure separately instead of using struct kprobe, so we do not pollute
>> code being used only for uprobes or other non-kprobes instruction
>> interpretation.
>>
>> Signed-off-by: David A. Long <dave.long@...aro.org>
>> ---
>>   arch/arm/include/asm/probes.h    |   9 +-
>>   arch/arm/kernel/kprobes-arm.c    |  77 ++++++-------
>>   arch/arm/kernel/kprobes-common.c |  42 ++++---
>>   arch/arm/kernel/kprobes-thumb.c  | 239 +++++++++++++++++++--------------------
>>   arch/arm/kernel/kprobes.c        |   2 +-
>>   arch/arm/kernel/kprobes.h        |   2 +-
>>   arch/arm/kernel/probes-arm.c     |  33 +++---
>>   arch/arm/kernel/probes-arm.h     |  29 ++---
>>   arch/arm/kernel/probes-thumb.c   |  18 ++-
>>   arch/arm/kernel/probes-thumb.h   |  51 ---------
>>   arch/arm/kernel/probes.c         |  14 ++-
>>   arch/arm/kernel/probes.h         |   8 +-
>>   12 files changed, 246 insertions(+), 278 deletions(-)
>
> Looks OK to me, though it looks like this patch includes some header
> file cleanups that should have been part of the previous patch? I.e. all
> the changes to probes-thumb.h and probes-arm.h. And also the
> re-application of 'static' to functions in kprobes-thumb.c and
> kprobes-arm.c.
>
> I'm not sure it's worth the hassle of trying to unpick those changes
> though, it doesn't impact the end result or bisect-bility.
>

I moved the changes around as suggested.

-dl

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/